Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

Refresh user providerData when the user log again #511 #1062

Closed
wants to merge 2 commits into from
Closed

Refresh user providerData when the user log again #511 #1062

wants to merge 2 commits into from

Conversation

junit38
Copy link

@junit38 junit38 commented Nov 16, 2015

The PR is refreshing the user providerData when the user is loggin again with a social account to maintain the accuracy of the data.

@codydaig
Copy link
Member

@junit38 Thanks for the PR! Couple things:

Ping me once these are addressed so we can review this PR. Thanks! :-D

Fix eslint

Fixes #82
@mleanos
Copy link
Member

mleanos commented Nov 18, 2015

@junit38 What are your thoughts on just updating the user's Token?

My idea is that we should treat whatever is in their MEANJS profile, as their master profile data. Meaning their data shouldn't be automatically synced with their Provider data.

In a separate feature PR, we could add a "Sync" button for pulling over their Provider data into their MEANJS profile. But that would require some discussion, and something we can try to add to 0.5.0 as a bonus feature.

@rhutchison
Copy link
Contributor

Duplicates #1070 - does this need to remain open?

@lirantal lirantal added this to the 0.5.0 milestone Dec 29, 2015
@codydaig
Copy link
Member

@junit38 I'm closing this for now. It does seem like a duplicate. Feel free to reopen if it needs to be open.

@rhutchison Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants