feat(chat): Modify chat module to implement johnpapa styleguide.

[rhutchison]

I know this will further stir the pot about which guidelines the project should follow, but the intention is not to delay progress, and instead push forward.

This is not up for debate - but I will take constructive feedback.

[mleanos]

can we abstract this out into a service?

[rhutchison]

That can be a separate PR?

[codydaig]

Agreed. That should be a separate PR.

[mleanos]

Since this is a styling refactor, I thought it would be good to address this as well; if we're strictly adhering to John Papa's style-guide. Might be worthwhile to start the precedent now, with regards to SOC & moving things out into services that shouldn't be in controllers.

It's ok if you want to leave this here though. I don't feel super strong about it :)

[ilanbiala]

LGTM mostly, @lirantal @codydaig 👀?

[codydaig]

I would like to see scope changed to $scope in the tests. But otherwise, LGTM.

[mleanos]

@codydaig What's the reasoning behind changing scope to $scope? Just to follow suit with the other services? If that's the case, then I'd say we should remove the "$" from the others.

[trainerbill]

LGTM, if it helps. excited to see progress on standards

[codydaig]

@mleanos It's to match how they are actually used. And in the code, it's referred too as $scope, so I don't think we should be changing how we reference it in the tests.

[ilanbiala]

Yeah definitely change to $scope

[ilanbiala]

I think this PR is fine, and we can immediately add another PR for the service @mleanos referred to. @codydaig once the $scope change is made and the commit message is reworded, LGTM and you can merge.

[codydaig]

@mleanos @ilanbiala @trainerbill I think that's the last piece holding up #874 as well is the $ in front of variables and maybe one of the controller/service names.

[mleanos]

@codydaig This PR is related to #874? Or you mean the changes we want here are similar to what we have left on #874? I'm eager to get that merged.

Thanks for clarifying about the $. That seems right to me too.

[ilanbiala]

Similarity of the $.

[rhutchison]

@ilanbiala @codydaig good to merge?

[ilanbiala]

@rhutchison @codydaig LGTM, just fix the commit message so it follows these guidelines https://github.com/meanjs/mean/blob/master/CONTRIBUTING.md#commit-message-guidelines

[mleanos]

LGTM. I took it for a test drive, and everything looks good, and is working as expected.

Thanks @rhutchison

[codydaig]

LGTM.

Thanks @rhutchison!!!