fix(build): Linting error at gulpfile.js

[simison]

Fixes an error occurring when running gulp:

/mean/gulpfile.js
  199:22  error  A space is required after '{'   object-curly-spacing
  199:42  error  A space is required before '}'  object-curly-spacing

[mleanos]

LGTM. Thanks, Mikael.

[codydaig]

LGTM

Why is the build passing then if there's a linting error?

[simison]

@codydaig It indeed does pass — odd enough.

It's unclear from which linter this error is coming from.

[mleanos]

I looked into it a little.. Couldn't tell which linter was causing the errors either. However, the errors don't cause a crash; even when starting the application.

When running grunt the lint errors aren't thrown. So there must be a difference in the linters that are being ran between Grunt & Gulp. I'll look into this further.

I didn't see the errors show up in the build log for the merge that introduced this. https://travis-ci.org/meanjs/mean/builds/102415414

What is initiating the linting & test tasks during the builds?

[mleanos]

It appears to be eslint that's throwing the errors.

Throws errors:

gulp eslint

Does not:

gulp jshint

It really is odd though because the eslint task is being ran during the build. I confirmed that the task was run (and didn't throw an error) in the build I shared above. Perhaps Travis build ignores such errors? I think I remember seeing jshint errors reflected in the Travis builds.

[simison]

I didn't dive deeper into this — simply cloned fresh repo, did npm install and gulp. Saw the error, fixed it. :-)

Glad you're at it!

[mleanos]

Thanks ;) Just wanted to share my findings since it was confusing why the build passed.

If needed we can open a new issue to continue the conversation, but it's not relevant to this fix.

[codydaig]

Let's move this to a new issue. I'll merge this in.