Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

(fix password-validator) Simple Mistype #1156

Closed
wants to merge 1 commit into from
Closed

(fix password-validator) Simple Mistype #1156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/users/client/services/password-validator.client.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ angular.module('users').factory('PasswordValidator', ['$window',
return result;
},
getPopoverMsg: function () {
var popoverMsg = 'Please enter a passphrase or password with greater than 10 characters, numbers, lowercase, upppercase, and special characters.';
var popoverMsg = 'Please enter a passphrase or password with more than 10 characters, numbers, lowercase, uppercase, and special characters.';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lirantal @codydaig Why do this when result tells us the errors? I think the popoverMsg should be result.requiredTestErrors if possible.

https://www.npmjs.com/package/owasp-password-strength-test#in-browser-1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilanbiala I think the point is to give the User a heads up on what the requirements are for the password. Rather than displaying the message on the page, I think this is a good way to convey this info to the User.

This doesn't have anything to do with the errors. The error result is handled through ng-messages, and displays on the page just like other form validation errors we have.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @Meistercoach83! @mleanos is right, the popover was intended to give the user instructions for the password requirements when they click into the form field.

return popoverMsg;
}
};
Expand Down