This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(Travis build): PhantomJS and SocketIO dependencies #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
codydaig
added a commit
that referenced
this pull request
Jan 27, 2016
fix(Travis build): PhantomJS and SocketIO dependencies
|
LGTM, not sure why those were not using |
|
@ilanbiala There seems to be a bunch that were/are like that. These in particular were breaking things so we fixed rapidly. |
|
Yeah, someone should probably do a dependency audit. I can't think of any reason why they wouldnt all be ~. Any breaking changes, ie minor/major upgrades, should be tested before. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed PhantomJS and SocketIO dependencies to ~ to stop breaking changes.