feat(gulp): Add gulp task mkdir:upload to ensure upload directory exi… #1199
Conversation
| @@ -202,6 +203,11 @@ gulp.task('imagemin', function () { | |||
| .pipe(gulp.dest('public/dist/img')); | |||
| }); | |||
|
|
|||
| // Make sure upload directory exists | |||
| gulp.task('mkdir:upload', function () { | |||
| return fs.mkdir('modules/users/client/img/profile/uploads', function () { }); | |||
There was a problem hiding this comment.
@rhutchison need to handle a possible error here.
There was a problem hiding this comment.
Error is handled with noop - how do you want it to be handled?
There was a problem hiding this comment.
log it or something maybe? We basically need to notify users of it at the least.
rhutchison
force-pushed
the
mkdir-upload
branch
4 times, most recently
from
5f0c9b8 to
4d9a444
Compare
| @@ -218,6 +218,15 @@ gulp.task('copyLocalEnvConfig', function () { | |||
| .pipe(gulp.dest('config/env')); | |||
| }); | |||
|
|
|||
| // Make sure upload directory exists | |||
| gulp.task('makeUploadsDir', function () { | |||
| return fs.mkdir('modules/users/client/img/profile/uploads', function (res) { | |||
There was a problem hiding this comment.
nitpick, res should be err (convention)
There was a problem hiding this comment.
Where is this convention defined?
This is a callback method for success/error and is not specifically a callback only for errors.
There was a problem hiding this comment.
It's a common node convention for callbacks to return an error, so err makes more sense.
|
Also, the scope of the commit message should be gulp, because this is gulp-related, not really "core". |
rhutchison
force-pushed
the
mkdir-upload
branch
from
4d9a444 to
4a298b4
Compare
rhutchison
changed the title
|
@ilanbiala scope is updated to reflect your feedback |
rhutchison
force-pushed
the
mkdir-upload
branch
from
4a298b4 to
6cacc15
Compare
|
@ilanbiala LGTY? |
|
Closing/Opening to produce clean build. One node timed out. |
feat(gulp): Add gulp task mkdir:upload to ensure upload directory exi…
…sts.
Related #1175