This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Update Mocha #1200
Merged
Update Mocha #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still erroring out: |
|
Based on mochajs/mocha#2102 (comment), it looks like mock-fs is the issue. I'll look into that. |
|
#1184 has been merged. |
|
Awesome, closed an reopened so Travis will re-run. |
|
@ilanbiala Passed. Squash, update commit message, and we can merge. |
|
LGTM |
ilanbiala
force-pushed
the
node5-support
branch
from
86a0bd1 to
62095a1
Compare
|
@codydaig if LGTY, go ahead and merge once tests pass. |
|
guys is this ready for primetime...mean for node-5.6 ? I would like to bang on it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha caused Node 5 tests to fail (https://travis-ci.org/meanjs/mean/jobs/108313328)