fix(users): Missing primary social provider #1241
Conversation
|
I haven't tested but LGTM. |
| @@ -1,6 +1,11 @@ | |||
| <section class="row" ng-controller="SocialAccountsController"> | |||
| <h3 class="col-md-12 text-center" ng-show="hasConnectedAdditionalSocialAccounts()">Connected social accounts:</h3> | |||
| <div class="col-md-12 text-center"> | |||
| <!-- If the user's provider field (primary) is a social account, show it here //--> | |||
There was a problem hiding this comment.
Just a habit. I can remove it.
There was a problem hiding this comment.
Should I remove the whole comment?
There was a problem hiding this comment.
No just the //, the comment is fine
There was a problem hiding this comment.
Ok. Will do. I think the habit stems from the good ole XML days :)
Adds the User's provider to the list of connect social accounts, when it is also a social account. Fixes: meanjs#1032
mleanos
force-pushed
the
fix/connected-accounts-not-shown
branch
from
40a1735 to
f2e18e2
Compare
|
@ilanbiala I've removed the I'm not really a UI guy, so I'm not sure if there's a better way to indicate that a Social provider is the User's Primary ( |
|
No, I think that's fine. We're not really building a UI framework anyway, it's just to have some sort of frontend. |
|
Merging.. We can discuss the other features that should go into Manage Social Accounts, and handle those enhancements in a new PR. |
fix(users): Missing primary social provider
Adds the User's provider to the list of connect social accounts, when it is also a social account.
This is the first step in solving the issue described in #1032. This at least fixes the bug, of the User's provider not showing up.
We could either merge this to satisfy the bug, and then proceed with the rest of the implementation discussed in the issue. Or we could add it to this PR. We'd still need to discuss, and come to a conclusion of how to handle the different scenarios that end User's can face.