fix(gulp): unhandled error (not printed for the user) #1261

lirantal · 2016-03-10T22:27:28Z

gulpfile.js had an handled error, or more precisely handled but the actual error wasn't printed to the screen.

mleanos · 2016-03-10T22:35:48Z

LGTM.

ilanbiala · 2016-03-11T16:26:31Z

gulpfile.js

@@ -327,6 +327,7 @@ gulp.task('protractor', ['webdriver_update'], function () {
      process.exit(0);
    })
    .on('error', function(err) {
+      console.log(err);


.error maybe? Also, why don't we put the E2E failing above it to give some context.

we use consistently console.log() on gulp/grunt. Should I change all of them to .error for consistency?

If it's an error, then yeah I think it makes sense.

cool, I'll update.

lirantal · 2016-03-12T14:25:28Z

@ilanbiala updated .error() related statements.

ilanbiala · 2016-03-12T17:36:07Z

gulpfile.js

@@ -327,7 +327,8 @@ gulp.task('protractor', ['webdriver_update'], function () {
      process.exit(0);
    })
    .on('error', function(err) {
-      console.log('E2E Tests failed');
+      console.error(err);
+      console.error('E2E Tests failed');


This should be above the error to give context.

@lirantal can you reorder these two statements before you merge?

sure, in this case I'll add a colon to the E2E Tests failed text too to make it clear

Yeah sounds good.

ilanbiala · 2016-03-12T17:38:40Z

Reran the build, hopefully it passes.

lirantal · 2016-03-12T20:10:54Z

Obviously the build doesn't fail due to the console.error() so apparently we have a bigger problem there? Looks related to protractor.

ilanbiala · 2016-03-12T22:18:04Z

Yeah, weird that Node 5 passes though...@mleanos @trendzetter @codydaig any ideas?

mleanos · 2016-03-12T22:52:53Z

I first saw this issue last night when I submitted a PR. I've been looking into it for a couple hours.

I went through one of the failed builds log, and compared it to a recent successful build we had. I was looking for differences in the packages installed, and any variations in the Travis environment. I couldn't find any differences that are relevant.

Now I'm getting the same exact error with both grunt test & gulp test locally, after blowing away node_modules, npm cache clean & npm install.

I'll start looking at the protractor project issues.

mleanos · 2016-03-12T22:56:01Z

Are you getting a TypeError: Cannot read property 'dropDatabase of undefined error thrown when running either grunt test:e2e or gulp test:e2e? It started showing up for me after I did a clean install of the project's node packages. Could be related.

mleanos · 2016-03-12T23:15:40Z

Seems to be an issue with Mongoose 4.4.7 which was released 23 hours ago. I installed 4.4.6 and the E2E tests are fine. It's kind of interesting that we didn't see anything with this in the logs that indicated the exception thrown on the dropdb task.

mleanos · 2016-03-12T23:36:16Z

Let's see if the builds succeed in #1264

mleanos · 2016-03-13T02:31:04Z

Re-ran the build since I merged in #1264

lirantal · 2016-03-13T13:29:00Z

Ok so I'm merging this one but for #1264 we need to investigate it further.

ilanbiala · 2016-03-13T17:36:31Z

@lirantal LGTM except one change that I would suggest that we reorder.

lirantal · 2016-03-14T06:40:01Z

updated re-ordering.

mleanos · 2016-03-14T06:57:16Z

LGTM. So the idea is to start using console.error in cases like this, throughout the framework?

lirantal · 2016-03-14T07:00:31Z

No, not through-out the framework, just in gulpfile.js.
For the framework we have a logging system (which I need to update)

On Mon, Mar 14, 2016 at 8:57 AM, Michael Leanos notifications@github.com
wrote:

LGTM. So the idea is to start using console.error in cases like this,
throughout the framework?

—
Reply to this email directly or view it on GitHub
#1261 (comment).

Sincerely, Liran Tal

Author
http://www.amazon.com/Agile-Software-Development-HP-Manager/dp/1484210352/of
Agile Software Development with HP Agile Manager
Founder and Lead Developer of daloRADIUS http://www.daloradius.com/
Blogging at http://www.enginx.com, and tweeting at @liran_tal
https://twitter.com/liran_tal

ilanbiala · 2016-03-14T14:10:15Z

LGTM.

rhutchison · 2016-03-17T14:42:27Z

LGTM

ilanbiala · 2016-03-17T15:52:11Z

@lirantal please rebase and the build should still pass barring any ESLint issues.

lirantal · 2016-03-17T17:32:59Z

I WILL NOT REBASE!!!

mleanos · 2016-03-17T18:55:24Z

RE-BRACE yo-self foo!

lirantal · 2016-03-17T20:12:52Z

whaaaaat? who you calling a foo?!

…or related console.log() to console.error()

codydaig · 2016-03-17T21:37:52Z

LGTM

ilanbiala · 2016-03-17T22:51:46Z

LGTM.

fix(gulp): unhandled error (not printed for the user)

lirantal self-assigned this Mar 10, 2016

lirantal added this to the 0.5.0 milestone Mar 10, 2016

lirantal added enhance:feature issue:bug and removed enhance:feature labels Mar 10, 2016

ilanbiala reviewed Mar 11, 2016
View reviewed changes

lirantal force-pushed the bugfix/gulpfile_lint_issues branch from e40fcf0 to 5a6d954 Compare March 12, 2016 14:25

ilanbiala reviewed Mar 12, 2016
View reviewed changes

lirantal force-pushed the bugfix/gulpfile_lint_issues branch from 5a6d954 to 6e9dc4c Compare March 14, 2016 06:39

fix(gulp): unhandled error in gulpfile and also changing existing err…

b4c9464

…or related console.log() to console.error()

lirantal force-pushed the bugfix/gulpfile_lint_issues branch from 6e9dc4c to b4c9464 Compare March 17, 2016 20:32

lirantal added a commit that referenced this pull request Mar 18, 2016

Merge pull request #1261 from lirantal/bugfix/gulpfile_lint_issues

8d137ac

fix(gulp): unhandled error (not printed for the user)

lirantal merged commit 8d137ac into meanjs:master Mar 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(gulp): unhandled error (not printed for the user) #1261

fix(gulp): unhandled error (not printed for the user) #1261

lirantal commented Mar 10, 2016

mleanos commented Mar 10, 2016

ilanbiala Mar 11, 2016

lirantal Mar 11, 2016

ilanbiala Mar 11, 2016

lirantal Mar 12, 2016

lirantal commented Mar 12, 2016

ilanbiala Mar 12, 2016

ilanbiala Mar 13, 2016

lirantal Mar 13, 2016

ilanbiala Mar 13, 2016

ilanbiala commented Mar 12, 2016

lirantal commented Mar 12, 2016

ilanbiala commented Mar 12, 2016

mleanos commented Mar 12, 2016

mleanos commented Mar 12, 2016

mleanos commented Mar 12, 2016

mleanos commented Mar 12, 2016

mleanos commented Mar 13, 2016

lirantal commented Mar 13, 2016

ilanbiala commented Mar 13, 2016

lirantal commented Mar 14, 2016

mleanos commented Mar 14, 2016

lirantal commented Mar 14, 2016

ilanbiala commented Mar 14, 2016

rhutchison commented Mar 17, 2016

ilanbiala commented Mar 17, 2016

lirantal commented Mar 17, 2016

mleanos commented Mar 17, 2016

lirantal commented Mar 17, 2016

codydaig commented Mar 17, 2016

ilanbiala commented Mar 17, 2016

fix(gulp): unhandled error (not printed for the user) #1261

fix(gulp): unhandled error (not printed for the user) #1261

Conversation

lirantal commented Mar 10, 2016

mleanos commented Mar 10, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lirantal commented Mar 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilanbiala commented Mar 12, 2016

lirantal commented Mar 12, 2016

ilanbiala commented Mar 12, 2016

mleanos commented Mar 12, 2016

mleanos commented Mar 12, 2016

mleanos commented Mar 12, 2016

mleanos commented Mar 12, 2016

mleanos commented Mar 13, 2016

lirantal commented Mar 13, 2016

ilanbiala commented Mar 13, 2016

lirantal commented Mar 14, 2016

mleanos commented Mar 14, 2016

lirantal commented Mar 14, 2016

ilanbiala commented Mar 14, 2016

rhutchison commented Mar 17, 2016

ilanbiala commented Mar 17, 2016

lirantal commented Mar 17, 2016

mleanos commented Mar 17, 2016

lirantal commented Mar 17, 2016

codydaig commented Mar 17, 2016

ilanbiala commented Mar 17, 2016