Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Fix(server): Remove unused loadModels() #1426

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Conversation

simison
Copy link
Member

@simison simison commented Aug 11, 2016

Remove unused loadModels() from app.js, as it doesn't seem to be used anywhere.

— or am I missing something?

It was added here: edb6234

@mleanos
Copy link
Member

mleanos commented Aug 13, 2016

I can't remember if we ever used this method, but I think the intention was to provide it for use where the server-side app module is accessible, but the mongoose module might not be. I'm not 100% sure on this though, and I've verified that this change wouldn't break anything (from what I can tell).

@lirantal Any insight into this?

@mleanos mleanos added this to the 0.5.0 milestone Aug 13, 2016
@lirantal
Copy link
Member

I added it as a helper function back then, we can remove it.

@lirantal lirantal merged commit 23fd205 into meanjs:master Aug 26, 2016
@simison
Copy link
Member Author

simison commented Aug 26, 2016

👍 Thanks for explaining & merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants