Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Add dockerfile and compose for production #1438

Merged
merged 3 commits into from
Aug 25, 2016

Conversation

FedeG
Copy link
Contributor

@FedeG FedeG commented Aug 20, 2016

feat(deploy) Add dockerfile and compose for production.

Add Dockerfile for production (#1431)
Add docker-compose.yml for production
Update documentation for deployment

Fixes #1435
Fixes #1431

FedeG added 3 commits August 20, 2016 00:27
Add Dockerfile for production

Fixes meanjs#1431 Fixes meanjs#1435
Add docker-compose.yml for production

Fixes meanjs#1435
Update documentation for production deployment

Fixes meanjs#1435
@lirantal
Copy link
Member

Thanks @FedeG.
Have you tested both dockerfile and the docker-compose file configuration to work well?

@lirantal
Copy link
Member

I tested it, seems to be ok including live reload for dev environment.

@lirantal
Copy link
Member

Actually FYI I tested the dev docker updates, haven't yet tested the production one.

@lirantal
Copy link
Member

@FedeG can you outline the differences from the dev docker setup? is it just the NODE_ENV defaulting to production in the dockerfile?

@FedeG
Copy link
Contributor Author

FedeG commented Aug 25, 2016

Differences:

  • In Dockerfile:
    • Simplify some commands
    • Add --production to npm install
    • NODE_ENV defaulting to production
    • Remove expose for debug port (remove EXPOSE 5858:5858)
  • In docker-compose.yml:
    • Change ports (remove 3000, 5858 and 35729 and add 8443)
    • NODE_ENV defaulting to production
    • Remove code volumes (change ./:/opt/mean.js to /opt/mean.js)
    • Remove expose db port (remove 27017 in mongo container)
  • Update documentation for deployment in production

@lirantal
Copy link
Member

Sounds good.
Thanks @FedeG.

@lirantal lirantal merged commit 25bd40c into meanjs:master Aug 25, 2016
@FedeG FedeG deleted the docker_compose_production branch August 26, 2016 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants