This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(core): Fixes issues with tests and Node v6 #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with Mocha tests and Node v6. Related to meanjs#1455
|
Very cool, thanks @simison! |
|
@lirantal this PR just fixes underlaying error we stumbled upon while looking into the issue #1455, but doesn't fix the initial problem he/she was reporting: ...at least we now know how to cause mocha error out easily. ;-) Kudos for @nicksellen for that semver fix btw, he made that for @Trustroots initially. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with Mocha tests and Node v6.
Basically updating
mock-fswould fix the issue, but updating Mocha to v3 as well while I’m at it…Tweaked tests to pass also under Mocha v3 and Node v6.
Related to #1455