feat(tests): Add client and server test coverage to Gulp

[hyperreality]

feat(tests): Add client and server test coverage to Gulp

This runs server-side test coverage using grunt-istanbul and sets karma
to run coverage tests, when gulp test:coverage is run.

I need a project maintainer to help integrate coveralls to this. After that is
done, Gulp should be 100% ready to replace Grunt.

Completes one of the #1175 milestones, also #1231 can be closed

[lirantal]

@hyperreality awesome, what do you need my help with?

[simison]

@hyperreality Could you change this, too: https://github.com/meanjs/mean/blob/master/.travis.yml#L41

[lirantal]

True, that will kick off the coveralls so we can see some results, and also maybe we should update the README/npm scripts in package.json for a coverage command.

[hyperreality]

@lirantal I wasn't quite sure how to integrate coveralls at the time, but I found a package gulp-coveralls so I'll have a go at implementing that with my next commit.

@simison yes I'll edit that with my next commit here, good catch.

[ilanbiala]

~

[hyperreality]

@ilanbiala thanks, noted.

[coveralls]

Changes Unknown when pulling 82c0ac58e28632cf85332f913fa67bf602e57a16 on hyperreality:gulp-coverage into * on meanjs:master*.

[coveralls]

Changes Unknown when pulling 82c0ac58e28632cf85332f913fa67bf602e57a16 on hyperreality:gulp-coverage into * on meanjs:master*.

[coveralls]

Changes Unknown when pulling 82c0ac58e28632cf85332f913fa67bf602e57a16 on hyperreality:gulp-coverage into * on meanjs:master*.

[coveralls]

Changes Unknown when pulling 82c0ac58e28632cf85332f913fa67bf602e57a16 on hyperreality:gulp-coverage into * on meanjs:master*.

[hyperreality]

Okay this is pretty weird stuff. Here are the results of the grunt coverage task: https://coveralls.io/builds/7677048
And here are the results of the new gulp coverage task: https://coveralls.io/builds/7677185

Karma is testing a different set of client side files each time! The original grunt coverage test misses out client-side directives, controllers and services. On the other hand, the gulp coverage test misses out all 'config' directory files which were included in the grunt task.

I'll take another look at this tomorrow.

[lirantal]

Ok, keep us posted @hyperreality, this one is really important to merge when ready.

[hyperreality]

Okay, I think I cracked it. There was a bug with the previous Grunt coverage tasks never submitting client-side tests to coveralls. This new Gulp coverage task fixes that by merging the client and server side test reports and submitting them together. Thus the number of files being recorded for coverage has increased.

Should be ready now I believe.

[hyperreality]

I can't seem to get the checks kicking off on this one.

[mleanos]

@hyperreality Looks like there's a conflict with your version of the branch & master. Try re-basing your local master branch from upstream, and then re-basing your PR branch from your local master.

[hyperreality]

@mleanos Cheers, I didn't see those new commits coming in.

[coveralls]

Changes Unknown when pulling 6aacfae on hyperreality:gulp-coverage into * on meanjs:master*.

[lirantal]

@hyperreality how is it now?
seems that the coverage is now back to testing only the unit tests, not e2e coverage as well. Can you take a look?

[hyperreality]

@lirantal I'm not sure what's going on. My personal builds are getting coverage for all tests: https://coveralls.io/builds/7697944

[lirantal]

Very odd.
I'll anyway merge this in and will appreciate if you can track it further to figure out. Maybe the travis build process is the issue.