This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
Update dockerfile for development and production #1491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… production and fix this bug meanjs#1453
Is this a replacement for #1468? |
yes, and add more improvements |
@FedeG should it still be possible to execute a shell on the development image such as with: |
@lirantal The command |
@lirantal When you send invalid container name to docker exec, the exec command returned EOF. |
Silly me, thanks for clearing out the confusion. Was on auto-pilot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(deploy) Update dockerfile for development and production.
Fix error #1453 (docker in production mode fails)
Add .dockerignore
Corrected SYNTAX some fixes #1468
Dockerfile optimized and improved
Dockerfile-production optimized and improved
Fixes #1468
Fixes #1453