Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Update dockerfile for development and production #1491

Merged
merged 6 commits into from
Sep 9, 2016

Conversation

FedeG
Copy link
Contributor

@FedeG FedeG commented Sep 8, 2016

feat(deploy) Update dockerfile for development and production.

Fix error #1453 (docker in production mode fails)
Add .dockerignore
Corrected SYNTAX some fixes #1468
Dockerfile optimized and improved
Dockerfile-production optimized and improved

Fixes #1468
Fixes #1453

@FedeG FedeG changed the title Update docker Update dockerfile for development and production Sep 8, 2016
@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage remained the same at 72.998% when pulling ff5a415 on FedeG:update_docker into 1a274d2 on meanjs:master.

@mleanos
Copy link
Member

mleanos commented Sep 8, 2016

Is this a replacement for #1468?

@FedeG
Copy link
Contributor Author

FedeG commented Sep 8, 2016

yes, and add more improvements

@lirantal lirantal merged commit e25670a into meanjs:master Sep 9, 2016
@lirantal lirantal self-assigned this Sep 9, 2016
@lirantal lirantal added this to the 0.5.0 milestone Sep 9, 2016
@lirantal
Copy link
Member

lirantal commented Sep 9, 2016

@FedeG should it still be possible to execute a shell on the development image such as with:
docker exec -it /bin/bash meanjs ?
I'm getting an EOF error which I didn't before.

@FedeG
Copy link
Contributor Author

FedeG commented Sep 9, 2016

@lirantal The command docker exec -it /bin/bash meanjs is invalid docker command, the correct command is docker exec -it meanjs /bin/bash
Docker exec sintax: docker exec -it <container_in_runtime> <command>

@FedeG
Copy link
Contributor Author

FedeG commented Sep 9, 2016

@lirantal When you send invalid container name to docker exec, the exec command returned EOF.
In your command, "/bin/bash" is the name of container and docker don't find this container.

@lirantal
Copy link
Member

lirantal commented Sep 9, 2016

Silly me, thanks for clearing out the confusion. Was on auto-pilot.

@FedeG FedeG deleted the update_docker branch September 9, 2016 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker in production mode fails
4 participants