Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Fix Heroku deployment issues #154

Closed
wants to merge 4 commits into from
Closed

Conversation

nickdandakis
Copy link

Had a hard time deploying to Heroku for relatively stupid reasons. Thought it would be nice if some minor changes could be done to make it deployable out of the box.

(First pull request ever! 👍 )

@rogelio-meza-t
Copy link

Have you some problem with forever module on Heroku?

@nickdandakis
Copy link
Author

It wasn't with the forever module. It was more with grunt not even recognising the gruntfile.js (because of a case mismatch), then grunt not running the task because Heroku was looking for the heroku:production grunt task.

@rogelio-meza-t
Copy link

Yep, I understand you. I made some changes in the procfile and now is running ok.

@gu-fan
Copy link

gu-fan commented Sep 5, 2014

Is mongoHQ always required??

@gu-fan
Copy link

gu-fan commented Sep 5, 2014

Followed this guide, worked.

But there is a problem.

when NODE_ENV set to 'product'.

the applicationJavaScriptFiles for ngmin's source is the 'application.min.js'
that made the application.min.js can not be updated

So I changed the config in loadConfig to

        var config = require('./config/env/all.js')

@ilanbiala
Copy link
Member

@Rykka @nickdandakis is there still a problem deploying to Heroku if you do a fresh git clone and deploy?

@lirantal
Copy link
Member

@nickdandakis sounds good to deploy to heroku although this PR doesn't seem to add anything new in automating this process except that it just adds some grunt task to build the project.

If you still think it's relevant please let's open a new PR against 0.4.0 branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants