This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Removed localhost from env files #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duce bugs in non-local environments.
|
+1 let's get this merged bruh |
rschwabco
added a commit
that referenced
this pull request
Oct 11, 2014
Removed localhost from env files
|
Thanks @wesleyfsmith ! |
rschwabco
added a commit
to meanjs/generator-meanjs
that referenced
this pull request
Oct 18, 2014
nishant8BITS
added a commit
to nishant8BITS/mean
that referenced
this pull request
Jun 22, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having http://localhost:3000 often causes me bugs when I am running different environments on a remote server. It's doesn't appear to be necessary, as the callback url seems to automatically route to the host machine whether I am running locally or remotely so it seems like it would be better to remove it.