This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Add comment to remind change for mongo replicaset connection (clean branch source) #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ff00ec9.
lirantal
suggested changes
Jan 6, 2017
|
Thanks @PierreBrisorgueil, I left a small comment if you can fix it I'll merge the PR. |
|
done, don't find how you configure your beautify :p |
|
LGTM. @lirantal I restarted the build, as I think changes you made recently have fixed the problem with Travis builds. If it passes, this should be ready. |
|
@lirantal The build is still failing. I think this change can be merged in regardless. Otherwise, we'd have to ask Pierre to rebase, but that seems unnecessary to me. |
lirantal
approved these changes
Apr 20, 2017
|
Agree, it's a comment change and we can definitely push, thanks @mleanos for triaging it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just add a quick comment, in order to remind to update configuration file if you try to connect your production to a cluster of mongo server.
server: { ssl: true, sslValidate: false, ....
must be
replset: { ssl: true, sslValidate: false, ....