This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
feat(Travis): Don't allow Node.js 8 testing fail #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So indeed seems like changin So let's wait until that gets merged in first and then we can merge this one. |
|
#1776 was all green (v6, 7 & 8) 👍 |
|
Yes it was when I merged it. I meant, was this PR green before? |
|
@lirantal nope this was failing for v8, lemme rebase now and let's see again. |
simison
force-pushed
the
patch-25
branch
2 times, most recently
from
9f95959 to
67ccc19
Compare
|
Aight, ✅ all green:
|
|
great! welcome to squash and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt like leaving these just uncommented so it helps in future when people want to add new versions here.
I can also remove them completely (or remove only
allow_failures) if you think it's better.