fix(eslint): Inconsistent spacing before function parentheses

[simison]

Defines space-before-function-paren eslint rule and changes files accordingly.

Resolves #1605

[mleanos]

LGTM. Thanks @simison. I tried using eslint --fix locally, and ran into issues. Must be an environment issue on my end.

[mleanos]

Coverage increased.. smh 😃

[simison]

Yeah I was lazy to figure out how to configure eslint -fix to catch correct config files and read correct directories/files, but I wrote a quick gulp task instead. ;-) Essentially just fix:true option in our eslint task + some small fiddling to get it save changes over old files.

[mleanos]

Would you like to share you Gulp task? I thought about doing the same yesterday :)

[simison]

@mleanos sure :-)

gulp.task('eslint-and-fix', function () {

  var gulpIf = require('gulp-if');
  var fs = require('fs');

  function saveFixedFile(file) {
    // Has ESLint fixed the file contents?
    if (file.eslint != null && file.eslint.fixed) {
      // Write file over with new fixed contents
      fs.writeFile(file.eslint.filePath, file.eslint.output, function(err) {
        if (err) {
          return console.log(err);
        }
      });
    }
  }

  var assets = _.union(
    defaultAssets.server.gulpConfig,
    defaultAssets.server.allJS,
    defaultAssets.client.js,
    testAssets.tests.server,
    testAssets.tests.client,
    testAssets.tests.e2e
  );

  return gulp.src(assets)
    .pipe(plugins.eslint({
      fix: true
    }))
    .pipe(plugins.eslint.format())
    // if fixed, write the file to dest
    .pipe(gulpIf(saveFixedFile, gulp.dest('./data/fixed')));
});

It's uggly, as I didn't figure out why gulp.dest didn't work (it would just spat files all over, now I just dump them to ./data/fixed which is gitignored). But whatever, it was just for one time use.

Remember to npm i gulp-if

Here's the original https://github.com/adametry/gulp-eslint/blob/master/example/fix.js