-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
Remove dependencies which are already installed via other dependencies: - eslint (gulp-eslint) - istanbul (gulp-eslint) - mocha (gulp-mocha) Remove unused dependencies: - eslint-config-airbnb - gulp-util Move installing `lcov-result-merger` to Travis config since it's the only place where it's ever used. Update a bunch of outdated dependencies.
if they're already installed through others then it's ok for now, we just need to keep an eye before they change it to peerDependencies and then we'll need to install them ourselves. About airbnb I left a comment on #1846 |
Yep; our Travis builds should fail at that point (unless Actually I'll drop eslint-airbnb change off from this PR, it's a separate issue to work on. |
Done here. BTW worth noting that I didn't update Mocha here yet, as it will require changes to test files as well. Opened an issue for reminder: #1848 |
alright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go
feat(build): Update dependencies (meanjs#1847)
Remove dependencies which are already installed via other dependencies: - eslint (gulp-eslint) - istanbul (gulp-eslint) - mocha (gulp-mocha) Remove unused dependency: - gulp-util Move installing `lcov-result-merger` to Travis config since it's the only place where it's ever used. Update a bunch of outdated dependencies.
Remove dependencies which are already installed via other dependencies:
Remove unused dependency:
Remove blackbox
eslint-config-airbnb
. Related #1846, #1674 — thoughts?Move installing
lcov-result-merger
to Travis config since it's the only place where it's ever used.Update a bunch of outdated dependencies.
Closes #1569