Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

feat(build): Update dependencies #1847

Merged
merged 7 commits into from
Aug 15, 2017
Merged

Conversation

simison
Copy link
Member

@simison simison commented Aug 14, 2017

Remove dependencies which are already installed via other dependencies:

  • eslint (gulp-eslint)
  • istanbul (gulp-eslint)
  • mocha (gulp-mocha)

Remove unused dependency:

  • gulp-util

Remove blackbox eslint-config-airbnb. Related #1846, #1674 — thoughts?

Move installing lcov-result-merger to Travis config since it's the only place where it's ever used.

Update a bunch of outdated dependencies.

Closes #1569

@simison simison self-assigned this Aug 14, 2017
Remove dependencies which are already installed via other dependencies:
- eslint (gulp-eslint)
- istanbul (gulp-eslint)
- mocha (gulp-mocha)

Remove unused dependencies:
- eslint-config-airbnb
- gulp-util

Move installing `lcov-result-merger` to Travis config since it's the only place where it's ever used.

Update a bunch of outdated dependencies.
@simison simison changed the title feat(build): Update dependencies [WIP] feat(build): Update dependencies Aug 14, 2017
@simison simison requested review from lirantal and mleanos August 14, 2017 23:14
@lirantal
Copy link
Member

if they're already installed through others then it's ok for now, we just need to keep an eye before they change it to peerDependencies and then we'll need to install them ourselves.

About airbnb I left a comment on #1846

@simison
Copy link
Member Author

simison commented Aug 15, 2017

if they're already installed through others then it's ok for now, we just need to keep an eye before they change it to peerDependencies and then we'll need to install them ourselves.

Yep; our Travis builds should fail at that point (unless node_modules is cached there). I tested installation with NPM 5.2.0

Actually I'll drop eslint-airbnb change off from this PR, it's a separate issue to work on.

@simison simison changed the title [WIP] feat(build): Update dependencies feat(build): Update dependencies Aug 15, 2017
@simison
Copy link
Member Author

simison commented Aug 15, 2017

Done here.

BTW worth noting that I didn't update Mocha here yet, as it will require changes to test files as well. Opened an issue for reminder: #1848

@simison simison added this to the 0.6.0 milestone Aug 15, 2017
@lirantal
Copy link
Member

alright.

Copy link
Member

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@simison simison merged commit b43c80e into meanjs:master Aug 15, 2017
@simison simison deleted the clean-package branch August 15, 2017 11:57
GulajavaMinistudio added a commit to GulajavaMinistudio/mean that referenced this pull request Aug 16, 2017
feat(build): Update dependencies (meanjs#1847)
cicorias pushed a commit to JavaScriptExpert/mean that referenced this pull request Sep 12, 2017
Remove dependencies which are already installed via other dependencies:
- eslint (gulp-eslint)
- istanbul (gulp-eslint)
- mocha (gulp-mocha)

Remove unused dependency:
- gulp-util

Move installing `lcov-result-merger` to Travis config since it's the only place where it's ever used.

Update a bunch of outdated dependencies.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants