Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Correcting Outdated Docs for Menu Service #281

Merged
merged 3 commits into from
Dec 3, 2014
Merged

Correcting Outdated Docs for Menu Service #281

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32b6ed9
Fix the issue documenting the menu service
NeverOddOrEven Nov 26, 2014
48bcbc6
Update the docs for addSubMenuItem
NeverOddOrEven Nov 26, 2014
ba537b9
Updating formatting
NeverOddOrEven Nov 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,7 +1930,7 @@ <h1>AngularJS Menus Service</h1>
</li>
</ol>
</dd>
<dt>Menus.addMenuItem(menuId, menuItemTitle, menuItemURL, [menuItemUIRoute], [isPublic], [roles]);</dt>
<dt>Menus.addMenuItem(menuId, menuItemTitle, menuItemType, menuItemURL, [menuItemUIRoute], [isPublic], [roles], [position]);</dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be Menus.addMenuItem(menuId, menuItemTitle, menuItemURL, menuItemType, [menuItemUIRoute], [isPublic], [roles], [position]); ?

<dd>
Creates a new menu item object. This method also include couple of arguments:
<ol>
Expand All @@ -1940,6 +1940,9 @@ <h1>AngularJS Menus Service</h1>
<li>
<b>menuItemTitle</b> (Required) - A String title for the menu item.
</li>
<li>
<b>menuItemType</b> (Required) - This can either be 'item' or 'dropdown'
</li>
<li>
<b>menuItemURL</b> (Required) - The path this menu item will link to.
</li>
Expand All @@ -1952,6 +1955,9 @@ <h1>AngularJS Menus Service</h1>
<li>
<b>roles</b> (Optional; Default: ['user']) - An array indicating the roles that are allowed to view this menu item.
</li>
<li>
<b>position</b> (Optional) - Specify the order of appearance
</li>
</ol>
</dd>
<dt>Menus.addSubMenuItem(menuId, rootMenuItemURL, menuItemTitle, menuItemURL, [menuItemUIRoute], [isPublic], [roles]);</dt>
Expand Down Expand Up @@ -1979,6 +1985,9 @@ <h1>AngularJS Menus Service</h1>
<li>
<b>roles</b> (Optional; Default: ['user']) - An array indicating the roles that are allowed to view this menu item.
</li>
<li>
<b>position</b> (Optional) - Specify the order of appearance
</li>
</ol>
</dd>
</dl>
Expand Down