This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Wait for async savings and removals #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is combined pull request. Removals in article could be done in parallel, then I suggest to make mongoose async by using bluebird promisify. Would that be okay? That would be another issue, and I can make a new pull request later for that. |
This was referenced Feb 18, 2015
Closed
Closed
|
Actually I had some randomly appearing errors caused by this issue. When I made this fix all to my tests those errors disappeared. |
| @@ -69,7 +70,8 @@ describe('User Model Unit Tests:', function() { | |||
| }); | |||
|
|
|||
| after(function(done) { | |||
| User.remove().exec(); | |||
| done(); | |||
| User.remove().exec(function(){ | |||
There was a problem hiding this comment.
Can't you pass done to .exec?
|
Now done is passed to exec as a parameter |
|
Same fixes here please. |
|
It seems to be already okay |
| Article.remove().exec(); | ||
| User.remove().exec(); | ||
| done(); | ||
| Article.remove().exec(function(){ |
|
Fixed formatting |
|
Great! @vepasto can you squash the commits down to 1 commit so that we don't pollute the commit log? I'll merge right after. |
|
Done |
ilanbiala
added a commit
that referenced
this pull request
Feb 23, 2015
Wait for async savings and removing in mocha tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.