This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
add return for done(err) in test #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
done. |
|
Looks good to you |
|
let's just wait for next week until we have a 0.4 merged-with-master branch and then we can merge this in. |
|
@lirantal can you merge? |
|
@lirantal shouldn't this either wait until 0.4.0 is fully merged into master or be merged into the release branch we have right now? |
|
@ilanbiala now that master_to_0.4.0 is merged I want to merge this into 0.4.0 branch, do you think there's a problem with that? |
|
Ah okay, yeah then that should be fine. |
ilanbiala
added a commit
that referenced
this pull request
Jul 9, 2015
Add return for done(err) in test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of double callback