Gulp updates #638
Gulp updates #638
Conversation
| @@ -9,7 +9,7 @@ | |||
| "curly": false, // Require {} for every new block or scope. | |||
| "eqeqeq": true, // Require triple equals i.e. `===`. | |||
| "immed": true, // Require immediate invocations to be wrapped in parens e.g. `( function(){}() );` | |||
| "latedef": true, // Prohibit variable use before definition. | |||
| "latedef": "nofunc", // Prohibit variable use before definition. | |||
There was a problem hiding this comment.
This change is to support angular best practices (as implemented in templates.js). Taken from angular-styleguide
|
github was having issues, reopening to trigger clean build. |
rhutchison
force-pushed
the
gulp-updates
branch
2 times, most recently
from
16f658f to
f1aae33
Compare
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| module.exports = { | |||
| secure: true, | |||
| port: process.env.PORT || 8443, | |||
| port: process.env.PORT || 8443, | |||
There was a problem hiding this comment.
Already handled in another PR
|
Grunt is being changed here as well. Why? |
|
@ilanbiala To ellaborate further on "Grunt vs Gulp", since allJS (assets definition) contained gruntfile.js as one of the src files, any changes to gruntfile.js would trigger a reload of gulp. This PR addresses this by separating the two. See the following: |
gulp should reload for gulpfile.js changes and grunt should reload for gruntfile.js changes. update template cache update template cache task flow use asset variable. indent
|
@rhutchison the path separator should probably be a separate PR. Also the template cache. Mixing all this into one PR makes it hard to analyze both to see if there's anything that can be optimized and any bugs that may come up. |
These are updates to gulp build automation.
Gulp Template Cache
Added angular-templatecache to cache templates for prod environment and combine with application.min.js. No more html files loaded in prod.
Auto Prefixer
As of bootstrap 3.2, vendor prefixes are deprecated in favor of autoprefixer.
Ref: https://github.com/twbs/bootstrap/blob/master/less/mixins/vendor-prefixes.less#L3
Path Separator
There is an issue on windows with path separator when compiling less/sass
Gym@43fade0#diff-b9e12334e9eafd8341a6107dd98510c9R126
Grunt vs Gulp
I have localized automation configuration changes to their respective config so that gruntfile.js changes do not restart gulp process and vice versus.
Gym@43fade0#diff-595bf3fa2348192244b0319be33066b8