appending a base tag to the head before jasmine tests run.

[cdriscol]

fixes #667

[lirantal]

@codydaig @mleanos @ilanbiala code review?

[codydaig]

LGTM. Doesn't effect the current tests in any way, and all tests pass regardless but I think it's a good addition for any future client side tests.

[cdriscol]

Yeah, doesn't really impact anything right now, but I needed it for creating some of these client tests.

[codydaig]

@cdriscol Those tests are looking good!

[lirantal]

@cdriscol it would be a great addition if you could add client side tests :)

[cdriscol]

@lirantal, I plan on adding all my current client side tests and more once I've had some time to refactor a bit.

You can assign #663 to me if you'd like.. I don't think I can assign it to myself..?

[lirantal]

@cdriscol sure, let's take it in #663

[lirantal]

@cdriscol when linting the code it reports the following issue:

Can you advise?

[lirantal]

@cdriscol actually when re-running it after an npm install I don't see the problem anymore. I'm not sure if it's something I missed or an actual problem, can you look into it just so we're on the safe side?

[cdriscol]

@lirantal - did a clean npm install and jshint passes with no errors.

I think the only way you'd get that not defined error is if your .jshintrc didn't have "jasmine": true or if your jshint was out of date (i.e. before they added jasmine 2.1 globals)

[lirantal]

@cdriscol got it, thanks. do we have the correct version now on 0.4.0 branch for jasmine on package.json ?

[cdriscol]

@lirantal - yeah, all of our current versions should be good in our package.json.