Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Switch TravisCI and DavidDM to 0.4.0 branch #682

Merged
merged 1 commit into from
Jul 22, 2015

Conversation

codydaig
Copy link
Member

In the README.md file on the 0.4.0 branch, the Travis-CI and David-DM badges were displaying the status of the Master Branch, not the 04.0 branch.

@ilanbiala ilanbiala added this to the 0.4.0 milestone Jul 22, 2015
@ilanbiala
Copy link
Member

@lirantal any issues? I think it's all good, pretty simple change.

@ilanbiala ilanbiala self-assigned this Jul 22, 2015
@lirantal
Copy link
Member

I understand why we are doing this now but let's think what we actually want. we always want to show the build status for 'master' branch, when we release 0.4.0 it will merged to master branch so generally the badges should always point to master branch.

Do you think otherwise? I'm not sure so many users are switching the default repository view to 0.4.0 and looking at the build status.

@codydaig
Copy link
Member Author

Personally, I like being able to see the dependency and build status of the master branch as well as the development branches. It seems misleading to go to the readme on the development branch and see that dependencies are out of date but in reality it's jut out of date for the master branch and they are up to date for the dev branch.

@ilanbiala
Copy link
Member

@lirantal Showing the corresponding dependency status and build status makes sense to me, the only thing I'm trying to work out is a way so we don't have to change this every time we create and merge a branch.

@lirantal
Copy link
Member

@ilanbiala exactly.
So I have an idea - @codydaig can you modify this PR to basically show badges for the stable master branch and for the dev (0.4.0) branch? so we basically have 2 lines of badges there.

Then we can have the same README for any branch, except we'll only need to update it when we change versions so the dev branch becomes 0.4.0, 0.5.0, etc which is ok to maintain.

WDYT?

@codydaig
Copy link
Member Author

@ilanbiala
Copy link
Member

@codydaig looks good, but can we move the Gitter badge onto a new line at the top?

@lirantal
Copy link
Member

@codydaig exactly. if you can visually make it look better (align-ness and stuff) but overall yeah, exactly that.

before we merge, can you please squash your commits?

@codydaig
Copy link
Member Author

@ilanbiala Like that?

@codydaig codydaig force-pushed the patch-2 branch 2 times, most recently from fbd3e08 to 72ae66a Compare July 22, 2015 17:47
@codydaig
Copy link
Member Author

@lirantal @ilanbiala

Commits have been squashed. If there's any more spacing/layout changes just let me know, otherwise it's ready.

@ilanbiala
Copy link
Member

Yep, LGTM. @lirantal LGTY?

@L1CH
Copy link

L1CH commented Jul 22, 2015

Hi @codydaig
can you check the link of Master Branch's Dependencies Status?
It seems also point to dev branch.

@codydaig
Copy link
Member Author

@L1CH Thanks! Forgot that DavidDM has links for specific branches while TravisCI doesn't.

@lirantal
Copy link
Member

Looks good @codydaig , @ilanbiala let's merge.

ilanbiala added a commit that referenced this pull request Jul 22, 2015
Switch TravisCI and DavidDM to 0.4.0 branch
@ilanbiala ilanbiala merged commit 29d264d into meanjs:0.4.0 Jul 22, 2015
@codydaig codydaig deleted the patch-2 branch July 22, 2015 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants