-
Notifications
You must be signed in to change notification settings - Fork 2k
Switch TravisCI and DavidDM to 0.4.0 branch #682
Conversation
@lirantal any issues? I think it's all good, pretty simple change. |
I understand why we are doing this now but let's think what we actually want. we always want to show the build status for 'master' branch, when we release 0.4.0 it will merged to master branch so generally the badges should always point to master branch. Do you think otherwise? I'm not sure so many users are switching the default repository view to 0.4.0 and looking at the build status. |
Personally, I like being able to see the dependency and build status of the master branch as well as the development branches. It seems misleading to go to the readme on the development branch and see that dependencies are out of date but in reality it's jut out of date for the master branch and they are up to date for the dev branch. |
@lirantal Showing the corresponding dependency status and build status makes sense to me, the only thing I'm trying to work out is a way so we don't have to change this every time we create and merge a branch. |
@ilanbiala exactly. Then we can have the same README for any branch, except we'll only need to update it when we change versions so the dev branch becomes 0.4.0, 0.5.0, etc which is ok to maintain. WDYT? |
@lirantal Something like this? |
@codydaig looks good, but can we move the Gitter badge onto a new line at the top? |
@codydaig exactly. if you can visually make it look better (align-ness and stuff) but overall yeah, exactly that. before we merge, can you please squash your commits? |
@ilanbiala Like that? |
fbd3e08
to
72ae66a
Compare
Commits have been squashed. If there's any more spacing/layout changes just let me know, otherwise it's ready. |
Yep, LGTM. @lirantal LGTY? |
Hi @codydaig |
@L1CH Thanks! Forgot that DavidDM has links for specific branches while TravisCI doesn't. |
Looks good @codydaig , @ilanbiala let's merge. |
Switch TravisCI and DavidDM to 0.4.0 branch
In the README.md file on the 0.4.0 branch, the Travis-CI and David-DM badges were displaying the status of the Master Branch, not the 04.0 branch.