This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
If displayName in Github is undefined #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codydaig
force-pushed
the
bugfix/github_undefined_displayname
branch
from
5b7417f to
7605956
Compare
|
@lirantal LGTY? |
|
works for now (no other option). What I would like to do, for all 3rd party providers, is drop you back to a form to complete any missing details. |
|
Yes, that looks ok. |
ilanbiala
added a commit
that referenced
this pull request
Jul 24, 2015
…name If displayName in GitHub is undefined use username Fixes #519
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user's displayName in github is undefined, default to the username.
Fixes #519