Gulp task enhancements - template cache #704

rhutchison · 2015-07-25T00:43:05Z

These are updates to gulp build automation.

Gulp Template Cache

Added angular-templatecache to cache templates for prod environment and combine with application.min.js. No more html files loaded in prod.

Auto Prefixer

As of bootstrap 3.2, vendor prefixes are deprecated in favor of autoprefixer.

Ref: https://github.com/twbs/bootstrap/blob/master/less/mixins/vendor-prefixes.less#L3

…r enabling GooglePlus API - Fixes meanjs#535

rhutchison · 2015-07-25T00:43:27Z

@ilanbiala please review

mleanos · 2015-07-25T01:07:44Z

LGTM.

ilanbiala · 2015-07-25T13:06:58Z

.jshintrc

@@ -9,7 +9,7 @@
 	"curly": false, // Require {} for every new block or scope.
 	"eqeqeq": true, // Require triple equals i.e. `===`.
 	"immed": true, // Require immediate invocations to be wrapped in parens e.g. `( function(){}() );`
-	"latedef": true, // Prohibit variable use before definition.
+	"latedef": "nofunc", // Prohibit variable use before definition.


What does "nofunc" mean?

to ignore function declarations - jshint/jshint#941

Taken from angular-styleguide

ilanbiala · 2015-07-26T02:48:49Z

@rhutchison squash?

rhutchison · 2015-07-26T02:50:30Z

@ilanbiala Wanted to give you time to review. You want it down to 1 commit?

ilanbiala · 2015-07-26T13:46:21Z

Yes please.

rhutchison · 2015-07-26T18:18:09Z

@ilanbiala ready for final review

ilanbiala · 2015-07-27T17:52:02Z

@rhutchison I like the idea and the implementation seems fine, but I'm trying to figure out how much the performance actually increases. Is there any way for you to maybe test a couple pages and see if it is indeed faster and by how much?

rhutchison · 2015-07-27T18:31:41Z

it will avoid the html download on every page load, so the rendering is much quicker. The performance will be based on the client internet connection/speed.

ilanbiala · 2015-07-27T18:47:59Z

Ok, until we remove Grunt, will this cause issues in the JS?

ilanbiala · 2015-07-29T12:07:19Z

@rhutchison since this only adds features and doesn't break anything, I'm moving this to 0.4.x and if it's ready for 0.4.0 in the next few days I'll move it back and merge, but there really isn't much rush to shove it out.

Fix the Google OAuth Redirect Bug - meanjs#535

rhutchison · 2015-07-30T03:43:44Z

@lirantal @ilanbiala I tested 'grunt prod' with these changes. I didn't notice any issues.

codydaig · 2015-07-30T05:22:56Z

LGTM

lirantal · 2015-07-30T06:35:16Z

@rhutchison yeah of course it will be pretty much ok since most of the change is on gulp.
On that - what does the template cache do and how does it work? I'm curious

Also, why do we need "latedef": "nofunc" ?

rhutchison · 2015-07-30T14:00:06Z

@lirantal #704 (comment)

template cache will look for all of the html files in the application and then compile them in to javascript statements and minify with the app, so all of the html is downloaded with the app. If you look at network traffic when you are using the app, whenever you change state, you will see the html is fetched, which will slow down the initial state load. What angular does is when the html is fetched from the server, it is put in template cache. This does that step at build time (on production).

lirantal · 2015-07-30T19:53:45Z

so basically template cache means all the HTML templates for Angular actually downloaded when the app first loads so that it doesn't need to go and download them later on?
I'm not against but it sounds to me like simply a trafe-off between when to download the templates, at first app load or later on one by one, and when the templates grow then this will mean more time to load the app on first load.

Link to editorconfig.org from CONTRIBUTING.md

Added Deploy To Bluemix button to the README

[fix] Was storing a 6 char password in plain text [fixes meanjs#829]

Correct <br /> Tags and set Title

…l not be mapped. Username will be generated from first initial of first name and last name. .jshint latedef set to nofunc.

current implementation does double redirect due to '#!'

local.example.js still has old fb auth callback

[Bug] Previous State (History)

mask exception route for 404 responses.

…links Refreshing the M.E.A.N links and description in the homepage

Added Auth Interceptor tests cleaned up test Update routes

remove data prefix from attributes. fix tests

Unauthorized client side routing

Facebook authentication

client-side form validation with ng-messages.

lint is already referenced in build task. missing env:prod add client/server test tasks Add template cache and autoprefixer. Update .jshintrc

rhutchison · 2015-08-26T05:04:29Z

Reopening against master

Correct the issue of Google OAuth2 redirect missing the hashbang afte…

7c015e2

…r enabling GooglePlus API - Fixes meanjs#535

rhutchison force-pushed the task-enhancements branch from 1b3b291 to 5a15f92 Compare July 25, 2015 01:37

ilanbiala reviewed Jul 25, 2015
View reviewed changes

ilanbiala added this to the 0.4.0 milestone Jul 25, 2015

ilanbiala added the enhance:feature label Jul 25, 2015

ilanbiala self-assigned this Jul 25, 2015

rhutchison closed this Jul 26, 2015

rhutchison force-pushed the task-enhancements branch from c943a28 to e1ca1aa Compare July 26, 2015 00:55

rhutchison reopened this Jul 26, 2015

rhutchison force-pushed the task-enhancements branch from 6cf9955 to ce5fca6 Compare July 26, 2015 18:17

ilanbiala modified the milestones: 0.4.x, 0.4.0 Jul 29, 2015

Merge pull request meanjs#568 from floydpink/feature-fix-535

3bc1de2

Fix the Google OAuth Redirect Bug - meanjs#535

rhutchison force-pushed the task-enhancements branch from ce5fca6 to 4e41dc5 Compare July 30, 2015 03:38

Initial support for deploying MEANJS to Cloud Foundry

efd3ee4

simison and others added 22 commits August 21, 2015 15:36

Link to editorconfig from CONTRIBUTING.md

601cf9f

Merge pull request meanjs#835 from simison/patch-12

37b0bdd

Link to editorconfig.org from CONTRIBUTING.md

Merge pull request meanjs#790 from ryanjbaxter/bluemix-button

9450c82

Added Deploy To Bluemix button to the README

Merge pull request meanjs#830 from codydaig/bug/password

7b880e9

[fix] Was storing a 6 char password in plain text [fixes meanjs#829]

Correct <br /> Tags and set Title

4b43c4e

Merge pull request meanjs#836 from Gym/0.4.1

b1f814e

Correct <br /> Tags and set Title

local.example.js still has old fb auth callback

3527537

Closes meanjs#202 - if user does not authorize email scope, email wil…

27d2818

…l not be mapped. Username will be generated from first initial of first name and last name. .jshint latedef set to nofunc.

use pushstate, fall back to window.location.hash.

b249512

current implementation does double redirect due to '#!'

mask exception route, but show not-found page.

9fdd2a0

do not save state to previous (history) for routes marked ignoreState.

c6d2683

Merge pull request meanjs#841 from Gym/master

51196c5

local.example.js still has old fb auth callback

Merge pull request meanjs#843 from Gym/bug-previous-state

cfe71bb

[Bug] Previous State (History)

Merge pull request meanjs#844 from Gym/404-behavior

b8147cb

mask exception route for 404 responses.

Refreshing the M.E.A.N links and description in the homepage

4a65439

Merge pull request meanjs#846 from lirantal/feature/refresh-homepage-…

979c4e5

…links Refreshing the M.E.A.N links and description in the homepage

Unauthorized client routing

ed89f9e

Added Auth Interceptor tests cleaned up test Update routes

client-side form validation with ng-messages.

8015476

remove data prefix from attributes. fix tests

Merge pull request meanjs#796 from trainerbill/UnauthorizedRoute2

2b015b0

Unauthorized client side routing

Merge pull request meanjs#842 from Gym/fb-enhancements

05355b9

Facebook authentication

Merge pull request meanjs#759 from Gym/client-side-validation

01bd98b

client-side form validation with ng-messages.

Task enhancements

1fa9776

lint is already referenced in build task. missing env:prod add client/server test tasks Add template cache and autoprefixer. Update .jshintrc

rhutchison force-pushed the task-enhancements branch 4 times, most recently from 4c007e3 to 1fa9776 Compare August 26, 2015 04:55

rhutchison closed this Aug 26, 2015

rhutchison mentioned this pull request Aug 26, 2015

Gulp task enhancements - template cache #853

Merged

rhutchison deleted the task-enhancements branch September 16, 2015 02:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gulp task enhancements - template cache #704

Gulp task enhancements - template cache #704

rhutchison commented Jul 25, 2015

rhutchison commented Jul 25, 2015

mleanos commented Jul 25, 2015

ilanbiala Jul 25, 2015

rhutchison Jul 25, 2015

ilanbiala commented Jul 26, 2015

rhutchison commented Jul 26, 2015

ilanbiala commented Jul 26, 2015

rhutchison commented Jul 26, 2015

ilanbiala commented Jul 27, 2015

rhutchison commented Jul 27, 2015

ilanbiala commented Jul 27, 2015

ilanbiala commented Jul 29, 2015

rhutchison commented Jul 30, 2015

codydaig commented Jul 30, 2015

lirantal commented Jul 30, 2015

rhutchison commented Jul 30, 2015

lirantal commented Jul 30, 2015

rhutchison commented Aug 26, 2015

Gulp task enhancements - template cache #704

Gulp task enhancements - template cache #704

Conversation

rhutchison commented Jul 25, 2015

Gulp Template Cache

Auto Prefixer

rhutchison commented Jul 25, 2015

mleanos commented Jul 25, 2015

ilanbiala Jul 25, 2015

Choose a reason for hiding this comment

rhutchison Jul 25, 2015

Choose a reason for hiding this comment

ilanbiala commented Jul 26, 2015

rhutchison commented Jul 26, 2015

ilanbiala commented Jul 26, 2015

rhutchison commented Jul 26, 2015

ilanbiala commented Jul 27, 2015

rhutchison commented Jul 27, 2015

ilanbiala commented Jul 27, 2015

ilanbiala commented Jul 29, 2015

rhutchison commented Jul 30, 2015

codydaig commented Jul 30, 2015

lirantal commented Jul 30, 2015

rhutchison commented Jul 30, 2015

lirantal commented Jul 30, 2015

rhutchison commented Aug 26, 2015