Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Enabling mongoose debug mode #707

Merged
merged 1 commit into from
Jul 26, 2015

Conversation

lirantal
Copy link
Member

Enhancing support for development environment to enable mongoose debug mode so that we can debug db queries

PR submitted out of original idea from #143

@lirantal lirantal self-assigned this Jul 25, 2015
@lirantal lirantal added this to the 0.4.0 milestone Jul 25, 2015
@mleanos
Copy link
Member

mleanos commented Jul 25, 2015

+1 LGTM. I'm excited to try this out.

@ilanbiala
Copy link
Member

@lirantal doesn't it print a lot more stuff? Shouldn't we check against an environment variable to see because I wouldn't want debug to always run..

@lirantal
Copy link
Member Author

@ilanbiala you're right I don't think it should be enabled by default, I'll update the PR.

@trainerbill
Copy link
Contributor

I honestly don't mind debug mode running in dev mode... But an env variable would be nice for production boxes. so you don't have to change code to go into debug mode. So I would add it to production.js with

production.js
process.env.MEAN_MONGOOSE_DEBUG || false

development.js
process.env.MEAN_MONGOOSE_DEBUG || true

@lirantal
Copy link
Member Author

I actually agree with @ilanbiala that user wouldn't want mongodb debug on, even on development environment, and I do like the environment variable idea so I'm combining it to this

debug: process.env.MONGODB_DEBUG || false

…g mode so that we can debug db queries

Includes support for environment variable MONGODB_DEBUG
@lirantal lirantal force-pushed the feature/mongoose_debug_option branch from ade07e2 to 0bcadcc Compare July 25, 2015 18:24
@ilanbiala
Copy link
Member

What about secure?

@lirantal
Copy link
Member Author

@ilanbiala you mean the environment config 'secure'? we don't have that on 0.4.0

@ilanbiala
Copy link
Member

Oh yeah right, then this is fine.

lirantal added a commit that referenced this pull request Jul 26, 2015
@lirantal lirantal merged commit 4f7aed0 into meanjs:0.4.0 Jul 26, 2015
@lirantal
Copy link
Member Author

Thanks guys.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants