Pagination Directive #795
Pagination Directive #795
Conversation
|
@ilanbiala I closed the last PR since it was going against 0.4.0. Can we get this agreed on and merged? @lirantal any comments? |
|
@trainerbill - need more Angular eyes to review this: @codydaig @mleanos @rhutchison |
| <ng-include src="meanPaginationUrl"></ng-include> | ||
| </div> | ||
| </div> | ||
| <input data-ng-show="meanPaginationSearch === 'true'" class="form-control col-md-4" type="text" data-ng-model="search" placeholder="Search" data-ng-change="figureOutItemsToDisplay()" /> |
|
@lirantal if we are going to move away from Bootstrap, I'd rather not merge this in. That said, we need to decide on that before this to proceed. |
|
I don't think anyone's plan is to move away from Bootstrap. |
|
I'm pulling this down to test and I noticed an issue with the spacing in modules/users/client/views/admin/user-list.client.view.html. It's tabs and it should be spaces. @lirantal @ilanbiala There was a discussion brought up recently when someone asked how to remove bootstrap, but that's all I remember hearing of that. I personally have no desire to get rid of bootstrap. |
|
There's no plan to move out of bootstrap. |
|
@lirantal ui-bootstrap hasn't been updated in a long time and Bootstrap's syntax is in no way semantic. I wouldn't add any code that depends on it, because frankly it isn't a framework that is well suited for Angular right now. |
|
@ilanbiala Looks like ui-boostrap gets continuous updates: https://github.com/angular-ui/bootstrap/commits/master unless you are talking about bumping the version in MEAN. What are the alternatives:
I will fix the indentation and let you guys figure out how to proceed. |
trainerbill
force-pushed
the
PaginationDirective2
branch
from
2a4541b to
f0837a1
Compare
Couple cleanups from our last convo Indent fix
trainerbill
force-pushed
the
PaginationDirective2
branch
from
9de5d30 to
a0ea427
Compare
|
Indentation is fixed. Took me like 5 commits to get it to work so I rebased. |
|
Whats the word on this? I was going to write some tests for the directive but if its not going to get merged I am not going to waste my time. @lirantal @codydaig @ilanbiala |
|
@trainerbill I'm not fond of building upon Bootstrap right now, I don't think it's the best idea since it hasn't kept up with Angular and we are planning on updating Angular. |
|
@ilanbiala Fair enough. The user admin module currently depends on it. Maybe we should look into doing a onmousewheel event to keep loading additional values into the list? That combined with the search function may be suitable and I could prolly make a directive for it. Also are you talking about boostrap-ui? Is there any other parts of the application that are using it? If not we should work to removing it as a dependency. |
|
There's a ticket for Material design #369 It's sorta bad timing right now when it comes to Angular + CSS frameworks... |
|
Bootstrap discussion aside, I like the pagination directive. Just write tests for it and make it fit the style guide and I think it should be good |
|
@codydaig once we move to Angular 1.4 or even 1.5, then ui-bootstrap will be an issue. I'd rather not add more code that prevents us from easily updating Angular, because that is a big priority since we are quite behind. |
|
@ilanbiala Sorry, should have read the chain of messages a little more throughly. |
|
@codydaig all good, I just want to make sure that anything we do won't inhibit our attempts at updating the core parts of the framework. |
|
@ilanbiala Angular 1.4 or 1.5? the hell with that. Let's just move straight to 2.0! :-) |
|
So I guess we are closing this one? |
|
@lirantal 2.0 still seems quite far away and honestly it seems like too much of a change for most developers. Since 1.5 is supposed to act as a migration update, I think we should go to 1.5 and work from there. Closing for now. @trainerbill a generic pagination directive may work, though we may need to do a little updating to get it to work with 1.5. |
closing #725
changed to master