Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Corrected 'prod' task in gulpfile #822

Merged
merged 1 commit into from
Aug 19, 2015
Merged

Corrected 'prod' task in gulpfile #822

merged 1 commit into from
Aug 19, 2015

Conversation

seanemmer
Copy link
Contributor

The current gulpfile 'prod' task runs the 'build' subtask which sets the environment variable to development. This pull request correctly sets the environment variable to production following completion of the build subtask.

@lirantal
Copy link
Member

@rhutchison ?

@rhutchison
Copy link
Contributor

LGTM

1 similar comment
@codydaig
Copy link
Member

LGTM

@lirantal lirantal self-assigned this Aug 19, 2015
@lirantal lirantal added this to the 0.4.x milestone Aug 19, 2015
@lirantal
Copy link
Member

Thanks guys

lirantal added a commit that referenced this pull request Aug 19, 2015
Corrected 'prod' task in gulpfile
@lirantal lirantal merged commit 3f76836 into meanjs:0.4.0 Aug 19, 2015
@mleanos
Copy link
Member

mleanos commented Aug 19, 2015

@lirantal This was merged into 0.4.0? Intentionally?

@lirantal
Copy link
Member

@mleanos thanks, I overlooked it as we're used to merging to production already.
@seanemmer can you please re-submit this PR for the master branch?

@seanemmer
Copy link
Contributor Author

@lirantal Will do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants