Adding MEAN.JS version information as part of the startup info when app loads #887
Conversation
|
👍 |
|
@lirantal What if someone changed the version in package.json to match their project's version? Why not have a meanjs-version attribute in package.json? That would also make things easier to managing versions in the generator and sub generators. I already have this in the proposed PR for the generator: |
|
Sure, that's even better. |
|
SGTM |
|
SGTM too! I like the idea of having both attributes displayed. |
|
Great, I updated |
|
|
| @@ -2,6 +2,7 @@ | |||
| "name": "meanjs", | |||
| "description": "Full-Stack JavaScript with MongoDB, Express, AngularJS, and Node.js.", | |||
| "version": "0.4.1", | |||
| "meanjs-sdversion": "0.4.1", | |||
There was a problem hiding this comment.
Is this a typo? Shouldn't it be "meanjs-version"?
There was a problem hiding this comment.
Thanks, good catch I fixed it.
…isplaying both MEAN.JS project and App project version numbers on start-up
lirantal
force-pushed
the
feature/app-startup-version-number
branch
from
1f6c4f1 to
a12746e
Compare
|
Fixed typo |
|
LGTM. Side note: you may want to set coveralls to allow a certain percentage of decrease because it's failing you right now. |
|
@lirantal is this going to be part of 0.4.2? |
|
@ilanbiala part of the next release so I guess 0.4.2. Why, is that an issue? |
|
@codydaig I see it but it's not a real error, it's just letting you know that coverage decreased (in this case in 0.08%), it didn't fail the build (tests) and it didn't dramatically reduce code coverage (it's a known issue that we don't yet have tests for core stuff outside of the users/articles modules) |
|
@lirantal just want to make sure it's in the right milestone for when we finalize the release and check the milestone for open issues. |
|
I updated it... |
|
This LGTM |
|
LGTM |
|
Great, thanks. |
Adding MEAN.JS version information as part of the startup info when app loads
I've been thinking it would be great if we can display the project version number when the app starts as that will easily allow other devs and users to clearly see which MEAN.JS release they are on.
We often get a lot of bug requests and this is usually the first version that comes up...
WDYT?