Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

fixed #953 - updated the correct URL in documentation and website to obtain the 0.4 version #981

Merged
merged 1 commit into from
Oct 16, 2015

Conversation

lirantal
Copy link
Member

Closes #953

@lirantal lirantal self-assigned this Oct 13, 2015
@lirantal lirantal added this to the 0.4.2 milestone Oct 13, 2015
@lirantal
Copy link
Member Author

@codydaig yours to review (it's a documentation update)

@codydaig
Copy link
Member

@lirantal I think it should be v0.4.1 to match the latest.

@mleanos
Copy link
Member

mleanos commented Oct 13, 2015

This says "..from the master branch.."
https://github.com/meanjs/mean/pull/981/files#diff-52d123e784c18e19488b96687c512943R60

Probably should match this with the version we're suggesting to download. I don't have a preference, as to which version we specify here. Master, v0.4.0, or v0.4.1 (latest) all seem appropriate; depending on our intention here.

@lirantal
Copy link
Member Author

You're both right, it should be pointing to the latest indeed. I'll update.

Regards,
Liran Tal.
On Oct 13, 2015 8:51 PM, "Michael Leanos" notifications@github.com wrote:

This says "..from the master branch.."

https://github.com/meanjs/mean/pull/981/files#diff-52d123e784c18e19488b96687c512943R60

Probably should match this with the version we're suggesting to download.
I don't have a preference, as to which version we specify here. Master,
v0.4.0, or v0.4.1 (latest) all seem appropriate; depending on our intention
here.


Reply to this email directly or view it on GitHub
#981 (comment).

@lirantal
Copy link
Member Author

Updated to reflect version v0.4.1

@@ -59,7 +59,7 @@
<p>
Another way to use the MEAN.JS boilerplate is to download a zip copy from the master branch on github. You can also do this using wget command:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lirantal Not trying to be nit picky :) but this sentence still says "master branch".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mleanos You should be as nit picky as required.
There's another line to update that I just noticed - I'll commit and push the change now.

@mleanos
Copy link
Member

mleanos commented Oct 14, 2015

Great :) LGTM

Thank you, Liran!

@codydaig
Copy link
Member

LGTM 👍
Thanks!

lirantal added a commit that referenced this pull request Oct 16, 2015
fixed #953 - updated the correct URL in documentation and website to obtain the 0.4 version
@lirantal lirantal merged commit 5fc52ae into meanjs:gh-pages Oct 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants