Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Adding karma coverage to grunt #985

Merged
merged 1 commit into from
Oct 17, 2015
Merged

Conversation

jloveland
Copy link
Contributor

Adding karma coverage for displaying client side test coverage when running grunt coverage.
karma-coverage

@@ -82,6 +82,7 @@
"grunt-ng-annotate": "^1.0.1",
"grunt-node-inspector": "~0.3.0",
"grunt-nodemon": "~0.4.0",
"grunt-protractor-coverage": "^0.2.15",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

@ilanbiala
Copy link
Member

@jloveland good start. Can you also add Gulp support?

@jloveland
Copy link
Contributor Author

@ilanbiala thanks for the review.

I would like to have the gulp karma coverage added in a different PR. Rationale is the following:

  1. Mean.js doesn't fully support gulp yet
  2. We don't even have a gulp coverage task for the server yet.

WDYT?

@jloveland jloveland changed the title Adding karma coverage Adding karma coverage to grunt Oct 15, 2015
@jloveland
Copy link
Contributor Author

also, what are your thoughts on outputting reports for client and server in coverage/client and coverage/server respectively?

@lirantal
Copy link
Member

👍 on adding coverage report for the client side
Sounds like a good idea to separate them for the future. People might be interested only in one aspect (client vs server) or will want to do different things with them in CI/CD process.

@ilanbiala
Copy link
Member

👍

@jloveland jloveland force-pushed the karma-coverage branch 2 times, most recently from 1f1baf0 to c49fd0a Compare October 16, 2015 01:12
@jloveland
Copy link
Contributor Author

@lirantal and @ilanbiala fixed conflicts, this should be ready to merge.

@ilanbiala
Copy link
Member

@lirantal should we see coverage in Coveralls already, or will we have to merge the PR?

@lirantal
Copy link
Member

IIRC you must merge first because it's just tracking the master branch.

ilanbiala added a commit that referenced this pull request Oct 17, 2015
@ilanbiala ilanbiala merged commit 76e11e4 into meanjs:master Oct 17, 2015
@ilanbiala ilanbiala added this to the 0.4.2 milestone Oct 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants