-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
@@ -82,6 +82,7 @@ | |||
"grunt-ng-annotate": "^1.0.1", | |||
"grunt-node-inspector": "~0.3.0", | |||
"grunt-nodemon": "~0.4.0", | |||
"grunt-protractor-coverage": "^0.2.15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~
@jloveland good start. Can you also add Gulp support? |
@ilanbiala thanks for the review. I would like to have the gulp karma coverage added in a different PR. Rationale is the following:
WDYT? |
also, what are your thoughts on outputting reports for client and server in |
👍 on adding coverage report for the client side |
👍 |
1f1baf0
to
c49fd0a
Compare
c49fd0a
to
c2b13b9
Compare
@lirantal and @ilanbiala fixed conflicts, this should be ready to merge. |
@lirantal should we see coverage in Coveralls already, or will we have to merge the PR? |
IIRC you must merge first because it's just tracking the |
Adding karma coverage for displaying client side test coverage when running
grunt coverage
.