This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
[bug] Favicon invalid path [fixes #979] #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleanos
force-pushed
the
favicon-path-bug
branch
from
4bdfaf7 to
0e8fd30
Compare
|
@lirantal I removed the Can someone shed some light on what Is this for redirection purposes? In order to know where the user came from? |
|
LGTM |
|
LGTM @mleanos |
Removed the {{url}} from the Favicon path. This fixes the intermittent
issues with the path resolving to an invalid location.
Removed the url from the twitter:image & og:image tags, to be static
references to the logo.
mleanos
force-pushed
the
favicon-path-bug
branch
from
0e8fd30 to
e6a5732
Compare
|
@lirantal Thank you for clarifying that. I've rebased & squashed. If we need to address any of the other META tags, then I can do so. Otherwise, I think this is ready. |
lirantal
added a commit
that referenced
this pull request
Oct 18, 2015
[bug] Favicon invalid path [fixes #979]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
{{url}}from the Favicon path. This fixes the intermittent issues with the path resolving to an invalid location.This seems to fix the bug with the Favicon invalid path. However, as discussed in #979, there are still remaining questions as to why these lines are using
locals.urlandlocals.logowith the META tagshttps://github.com/meanjs/mean/blob/master/modules/core/server/views/layout.server.view.html#L17-L29
Does anyone have any insight into these, and how we should address these issues? I think it would be appropriate to address all these issues in this PR. We just need to decide on how.