Adding configuration to fail grunt task if e2e tests fail

[jloveland]

fixing #961, failing grunt task will fail the travis build which is the desired behavior

[jloveland]

@codydaig, I purposely failed the build so you can see this config works.
see here: https://travis-ci.org/meanjs/mean/builds/85657476

[codydaig]

LGTM
@jloveland Thanks! :-D

[mleanos]

LGTM too! Thanks!

I am wondering, and just throwing this out there, if we want to add the keepAlive setting into the env config? How useful would this be for development purposes?

[ilanbiala]

The default is false, right? I'd rather just remove it because it's the behavior we expect and Grunt isn't as clear as it could be anyway.

[codydaig]

@mleanos I don't see a use case where that would be beneficial of the top of my head. Since the e2e tests run last, you'd still find out if any of your server or client tests failed first before hitting the e2e tests. When would you want to a build to pass even though the e2e tests weren't?

[mleanos]

@codydaig I guess my thought was that in a certain environment (development/staging), you may want the Grunt task to continue running even when a E2E test fails.

The idea was mostly just an afterthought :)

[jloveland]

For the keepAlive config, I was thinking it would be handy to have it there, then add another PR for adding grunt watch so, we can develop e2e tests have it continually run grunt tests after saving the test files..
https://www.credera.com/blog/technology-insights/java/testing-angularjs-part-5-protractor-grunt/

[codydaig]

@ilanbiala Are you okay with keepAlive being left in there, or do you want it removed before I merge?

[ilanbiala]

Remove it please.

[jloveland]

@ilanbiala and @codydaig will do.

[codydaig]

Thanks @jloveland! :-)