Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paint] solve problems switching between tools (#770) #1193

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[Paint] solve problems switching between tools (#770) #1193

merged 1 commit into from
Jan 22, 2024

Conversation

mathildemerle
Copy link
Collaborator

From PR Inria-Asclepios#770

This PR solves problems using tools in Paint:

  • Paint/Erase and Magic Wand buttons do not set properly their widgets.
  • Clear button was hiding buttons even if data were in the view, run twice a part of the cleaning process, then and Add and Erase buttons when shown were not handled well.

Ⓜ️

@mathildemerle
[Paint] solve problems switching between tools (medInria#770)
4f37369 
* [Paint] solve problems switching between tools

* Update medAlgorithmPaintToolBox.cpp : && instead of &&

* [Paint] separate condition for add and erase
@mathildemerle mathildemerle added this to the 3.4 milestone Jan 22, 2024
Florent2305
Florent2305 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@Florent2305 Florent2305 merged commit 3e3d724 into medInria:medInria3.4.x Jan 22, 2024
@mathildemerle mathildemerle deleted the paintSwitch branch January 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florent2305 Florent2305 Florent2305 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mathildemerle @Florent2305