Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jmzIdentML and adding Comet TSV parser #203

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

julianu
Copy link
Contributor

@julianu julianu commented Dec 15, 2023

  • updating jmzIdentML to version 1.2.13, which needs change of some dependencies and setting of AddOpens to manifest
  • adding parser for Comet TSV files

- necessary to also add some more parameters and AddOpens to java
runtime
- necessary to also add some more parameters and AddOpens to java
runtime
@codecov-commenter
Copy link

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (c31ce5f) 62.03% compared to head (e041584) 62.29%.
Report is 3 commits behind head on main.

Files Patch % Lines
...piler/parser/searchengines/CometTSVFileParser.java 79.05% 27 Missing and 13 partials ⚠️
...ermediate/compiler/parser/MzIdentMLFileParser.java 88.23% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #203      +/-   ##
============================================
+ Coverage     62.03%   62.29%   +0.26%     
- Complexity     2493     2524      +31     
============================================
  Files           139      140       +1     
  Lines         14902    15110     +208     
  Branches       2635     2660      +25     
============================================
+ Hits           9244     9413     +169     
- Misses         4600     4627      +27     
- Partials       1058     1070      +12     
Flag Coverage Δ
unittests 62.29% <80.37%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julianu julianu merged commit 8817dfb into medbioinf:main Dec 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants