Sextou handler #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liverday
requested changes
Apr 1, 2023
liverday
reviewed
Apr 2, 2023
handlers/friday.go
Outdated
|
|
||
| query := req.URL.Query() | ||
| query.Add("q", q) | ||
| query.Add("key", "LIVDSRZULELA") |
There was a problem hiding this comment.
Can you change this line to get the token from the environment?
There was a problem hiding this comment.
I didn't understand, you say to edit specifically the commit that entered this key? Because in the last commit i changed to get from the env
liverday
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a simple handler that reads all messages channel and if the message content contains the Friday trigger ("Friday") sends the gif if it is indeed Friday.
What would you do differently to my code?
Is to filter by specific channel, to read messages only from that channel?