fix bgc_data import issue #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we can add the other two fixes from here: #118 also to the release ? |
adraismawur
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current release does not work via pip or conda.
This PR tries to use this idea to fix it:#118
Now the package should work locally and installed via pip / conda.
Would it be possible, that you release this fix as 1.1.8; that would allow us to create the build.
As a short explanation, we are trying to integrate this tool into Galaxy (https://usegalaxy.eu/), but therefore we need a working bioconda recipe.
If you do not want to follow this up, would you mind if the release the bioconda recipe via a fork where we add those fixes ?