Look for duration in format if not available in stream #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 84.82% 85.25% +0.42%
==========================================
Files 3 3
Lines 145 156 +11
==========================================
+ Hits 123 133 +10
- Misses 22 23 +1
|
sumandari
reviewed
May 3, 2023
FredHaa
deleted the
124-current-uploader-package-thrown-error-during-reading-ffprobe-stream-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mediacatch/s3-upload-api/issues/124
We first check audio stream for duration in case video and audio streams are not of same length.
If duration isn't found the format field is used as backup.