Skip to content

Commit

Permalink
Added form.test.js and removed JsTestDriver equivalent.
Browse files Browse the repository at this point in the history
Modified if documentation to be more friendly with developers.
  • Loading branch information
Carlos Lizaga committed Dec 1, 2017
1 parent de225a9 commit 9f14822
Show file tree
Hide file tree
Showing 3 changed files with 268 additions and 244 deletions.
241 changes: 0 additions & 241 deletions dev/tests/js/JsTestDriver/testsuite/mage/form/form-test.js

This file was deleted.

9 changes: 6 additions & 3 deletions dev/tests/js/jasmine/tests/lib/mage/dropdown.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,12 @@ define([
jasmine.clock().uninstall();
});

// Backend jquery-ui version has a diferent behavior on create that will add ui-dialog-titlebar anyway.
// This test is only valid with frontend's version
// @TODO: Re-design Jasmine settings to match a selective architecture for testing in order to split them.
/*
* jQuery ui version 1.9.2 belongs to the adminhtml.
*
* This test will fail on backend since backend's jquery.ui will
* add ui-dialog-titlebar class anyway on create.
*/
if ($.ui.version !== '1.9.2') {
it('check if the title bar is prevented from being created', function () {
var dialog = $('<div/>'),
Expand Down
Loading

0 comments on commit 9f14822

Please sign in to comment.