Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium fix related to audio types #1843

Merged
merged 7 commits into from
Sep 17, 2016
Merged

Chromium fix related to audio types #1843

merged 7 commits into from
Sep 17, 2016

Conversation

rafa8626
Copy link
Contributor

@rafa8626 rafa8626 commented Sep 16, 2016

Chromium was not allowing to play audio files; this PR fixes #1520, #1670, #1831 and #1816

@mediaclap
Copy link

@rafa8626
Copy link
Contributor Author

I'll check this since I don't have an instance of Linux to test Chromium

@rafa8626
Copy link
Contributor Author

@mediaclap I got access to an Ubuntu machine and I checked on Chromium and I can hear the audio. What is what you are experiencing?

@rafa8626
Copy link
Contributor Author

My Chromium version is

Version 51.0.2704.106 Built on Ubuntu, running on Ubuntu 16.04 (64-bit)

@mediaclap
Copy link

mediaclap commented Sep 16, 2016

mine is Version 52.0.2723.2 (64-bit) on windows

link to download : https://sourceforge.net/projects/crportable/files/

@rafa8626
Copy link
Contributor Author

@mediaclap I see the controls now. I just updated Ubuntu and now my Chromium version is 53.0.2785.89. I checked the main site (http://mediaelementjs.com) and controls are not there. But in the one you just shared I can see controls. Am I missing something, or there's another issue?

@mediaclap
Copy link

mediaclap commented Sep 16, 2016

did you test with windows version ?

@mediaclap
Copy link

link to download : https://sourceforge.net/projects/crportable/files/

@mediaclap
Copy link

in http://dev-prod.multimedia.editions-mediaclap.fr/html/prod-test/js/johndyer-mediaelement-3e9d1ee/test/test.html i've change the source with the PR fix ! but in my windows version its not ok !

@rafa8626
Copy link
Contributor Author

rafa8626 commented Sep 16, 2016

I just have a Unix and Mac machines with me. I don't have a Windows machine with me. Can you send me a screenshot of what you are seeing, or even what you are getting from Console or Network tabs to try to determine what's going on please? Thanks for your patience and help with this. I'll try to get a Win instance as soon as possible

@rafa8626
Copy link
Contributor Author

Which version of Windows do you have?

@isantolin
Copy link
Contributor

@Ron666 @mediaclap I tested on Windows 7 32 Bits - Chromium 54. Doesn't play And console shows that info

Resource interpreted as Document but transferred with MIME type video/mp4: "http://dev-prod.multimedia.editions-mediaclap.fr/html/prod-test/js/johndyer-mediaelement-3e9d1ee/media/echo-hereweare.mp4".

Resource interpreted as Document but transferred with MIME type audio/mpeg: "http://dev-prod.multimedia.editions-mediaclap.fr/html/prod-test/js/johndyer-mediaelement-3e9d1ee/media/test.mp3".

That is because Chromium doesn't have support for privative formats

https://www.chromium.org/audio-video

And is supported when is build as Chrome, not Chromium

@rafa8626
Copy link
Contributor Author

@mediaclap As @isantolin said, this is a known bug from Chromium on Windows. On Ubuntu this can be fixed by running http://thanhsiang.org/faqing/node/195.

As an alternative solution for this, try the steps listed on http://www.chromestory.com/2010/11/how-to-make-chromium-os-play-mp3-files-on-windows-linux-and-mac/.

This is not related to this plugin anymore. And as it is concerned to this PR, it solved the issue related to not being able to display the audio controls in Chromium.

…n Flash valid types as an attempt to play them properly
@rafa8626
Copy link
Contributor Author

@mediaclap and @isantolin I changed the PR slightly; please test and let me know. Thanks for your help on this one

@isantolin
Copy link
Contributor

@Ron666 That PR Works well in IE, FF, Chrome. I think you can merge

@rafa8626
Copy link
Contributor Author

Did you give it a try on Chromium as well?

@isantolin
Copy link
Contributor

@Ron666 Chromium has the current bug "privative formats" and cannot play. Beyond that, PR don't create any other error. Merge

@rafa8626
Copy link
Contributor Author

rafa8626 commented Sep 17, 2016

Thanks @isantolin I'll merge as soon as I'm front of my computer. Thanks again for your help

@rafa8626 rafa8626 merged commit 605335d into mediaelement:master Sep 17, 2016
@rafa8626 rafa8626 deleted the chromium-fix branch September 17, 2016 17:54
@rafa8626
Copy link
Contributor Author

Closing this issue since PR was merged and per comments above

@pixelastic
Copy link

Sorry to bump this closed issue, but it is not fixed on my side. I am using Chromium, but I have also installed the required dependencies to be able to read mp3 files. It works well with a classical audio tag, but fails if I include mediaelement version 2.23.

Simple <audio> tag

image
image

<audio> tag and mediaelementjs v2.23

image
image

I'm loading 2.23 from jsdelivr, and for what it's worth, the following code returns true on my configuration (taken from here):

var a = document.createElement('audio');
return !!(a.canPlayType && a.canPlayType('audio/mpeg;').replace(/no/, ''));

I'm happy to provide any more information or testing time as you might need.

@rafa8626
Copy link
Contributor Author

Thanks for pointing this. I'll take a look and if needed I'll ask you for more testing

@rafa8626
Copy link
Contributor Author

If you can also provide a URL to test it I'll appreciate it

@rafa8626
Copy link
Contributor Author

And also the OS you tested this

@pixelastic
Copy link

Here is the url used as a test: http://roleplay.pixelastic.com/underground/murailles.html
Note that I have removed mediaelement from the page for now.

OS is Ubuntu 16.04, with Chromium Version 52.0.2743.116 Built on Ubuntu , running on Ubuntu 16.04 (64-bit)

@rekcuFniarB
Copy link

rekcuFniarB commented Sep 19, 2016

Chromium under Linux still fails. I downloaded latest mejs build from here.

Example with ogg only supplied: no playback (screenshot)

Example with ogg and mp3 supplied: chromium plays mp3 via flash plugin instead of html5 ogg (in the screenshot you can see that swf file was downloaded).

By the way, in this example without mejs my Chromium also plays mp3 without flash via native html5 player (screenshot).

But no problem in Firefox.

OS: Ubuntu 16.04.1 x86_64, Chromium: 52.0.2743.116

@rafa8626
Copy link
Contributor Author

rafa8626 commented Sep 19, 2016

@rekcuFniarB The build files have not the fix available; please test this using only the src files, given that this hasn't been released yet. For reference, check /test/test.html to load all the needed elements

@rafa8626
Copy link
Contributor Author

rafa8626 commented Sep 19, 2016

@pixelastic Enable mediaelement again but use the /src/ files, since the /build/ folder doesn't account for the fix yet, until the next release is created. For reference, check /test/test.html to load all the needed elements

@mediaclap
Copy link

@pixelastic i ve same probleme with my chromium version mp3 play but no control display with mejs !

@rafa8626
Copy link
Contributor Author

@pixelastic Can you send me the URL where you used the mejs src files so I can see the issue, please?

@rekcuFniarB
Copy link

@rekcuFniarB The build files have not the fix available; please test this using only the src files, given that this hasn't been released yet. For reference, check /test/test.html to load all the needed elements

This way it works, thanks for fixing.

@pixelastic
Copy link

I just tried with the src/ folder files and it's working. Silly me, I saw a 2.23 on jsdelivr and a 2.22 on the website and thought you released a new version with the fix.

All is working, thanks for investigating :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin doesn't work in the Chromium browser with audio files
5 participants