-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.2 upgrade #399
4.2 upgrade #399
Conversation
philipkozeny
commented
Nov 29, 2022
•
edited
Loading
edited
- support nominatim 4.2
- add 4.2 to supported versions (4.0, 4.1, 4.2)
- update 4.1 docs
This looks really good. I'm going to wait for the CI to pass before approving. Thanks! |
We are now supporting 3 versions of nominatim where before we did 2. Is this intentional? Not that it's a huge burden but I was wondering. |
Yeah this time it was intentional since the difference between the versions is marginal and the release cycle of nominatim is way shorter now. Although thinking about it, the base image (Ubuntu 20.x vs 22.x) has changed. So If you also don't have a good argument, I would remove the support from 4.0 :) |
Yes, please remove support for 4.0. |
remove 4.0 from the list of supported versions and deprecate it with the 4.2 release [skip ci]
Ok, and do you still want to build the image? |
remove 4.0 from build process
no, just way too tired and overlooking things 😂 thanks for the catch |
You have a [ci skip] in the squashed merge commit so the master ci doesn't run. |
i know, thanks - i have seen it after the merge. just looking if i can manually trigger it or if i really need to create another commit. |