feat: ffmpeg sidecar

mediar-ai · Nov 11, 2024 · e70445b · e70445b
1 parent 93a4f6b
commit e70445b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/screenpipe-app-tauri/src-tauri/Cargo.toml b/screenpipe-app-tauri/src-tauri/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "screenpipe-app"
-version = "0.10.4"
+version = "0.10.5"
 description = ""
 authors = ["you"]
 license = ""

diff --git a/screenpipe-server/src/video.rs b/screenpipe-server/src/video.rs
@@ -5,7 +5,6 @@ use log::{debug, error};
 use log::{info, warn};
 use screenpipe_core::{find_ffmpeg_path, Language};
 use screenpipe_vision::{continuous_capture, CaptureResult, OcrEngine};
-use std::env;
 use std::path::PathBuf;
 use std::process::Stdio;
 use std::sync::Arc;
@@ -168,6 +167,11 @@ pub async fn start_ffmpeg_process(output_file: &str, fps: f64) -> Result<Child,
         "pad=width=ceil(iw/2)*2:height=ceil(ih/2)*2",
     ];
 
+    // TODO: issue on macos https://github.com/mediar-ai/screenpipe/pull/580
+    #[cfg(target_os = "macos")]
+    args.extend_from_slice(&["-vcodec", "libx264", "-preset", "ultrafast", "-crf", "23"]);
+
+    #[cfg(not(target_os = "macos"))]
     args.extend_from_slice(&["-vcodec", "libx265", "-preset", "ultrafast", "-crf", "23"]);
 
     args.extend_from_slice(&["-pix_fmt", "yuv420p", output_file]);