Improve version extraction logic in fetch_latest_version script. #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Updates GitHub release version parsing logic to work reliably across different platforms Uses grep and sed for more robust version number extraction from API response: The new approach is more reliable because: - It doesn't depend on platform-specific behavior of text processing tools - It's more tolerant of formatting variations in the JSON response - It uses fewer pipe operations, reducing the chance of errors
fortran01
force-pushed
the
fix/install-script-version-parsing
branch
from
dae5c8b to
1efc38d
Compare
|
I got it. I'm on Mac, and you are on Linux. Created a new one #1048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pr] fix: improve version parsing reliability in install script
description
This PR improves the version parsing logic in the installation script to make it more reliable when fetching the latest version from GitHub. The changes handle potential formatting issues in the JSON response by:
related issue: # (no related issue)
how to test
curl -fsSL raw.githubusercontent.com/fortran01/screenpipe/fix/install-script-version-parsing/install.sh | sh