Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better mirror for ffmpeg downloads #644

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

Neptune650
Copy link
Contributor

@Neptune650 Neptune650 commented Nov 6, 2024

@louis030195 Fixes the mirrors used to download the ffmpeg binaries - these are listed in the official ffmpeg page so i'd say they're good to use.

Mostly so we don't get blocked by SourceForge.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 11:56pm

@louis030195 louis030195 merged commit 93ce6f4 into mediar-ai:main Nov 6, 2024
3 of 7 checks passed
@louis030195
Copy link
Collaborator

@Neptune650 nice

hope it wont cause issue with different ffmpeg version on encoding,decoding, etc

@Neptune650
Copy link
Contributor Author

@Neptune650 nice

hope it wont cause issue with different ffmpeg version on encoding,decoding, etc

@louis030195 Something that escaped me
In:

-o ./${config.macos.ffmpegName}

There shouldn't be a space, please change it to:

-o${config.macos.ffmpegName}

@Neptune650 Neptune650 deleted the patch-1 branch November 6, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants