Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x256): add x256 support #671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

developerfred
Copy link

@developerfred developerfred commented Nov 13, 2024

/claim #666
/closes #666

This PR uses the changes from #580 and adds Key Improvements:

  • Added automatic x265 codec detection on macOS systems
  • Implemented intelligent fallback to x264 when x265 is unavailable
  • Optimized encoding parameters for both x265 and x264 codecs
  • Enhanced error handling and logging for better diagnostics

related issue: #666

type of change

  • bug fix
  • new feature
  • breaking change
  • documentation update

checklist

  • MOST IMPORTANT: this PR will require less than 30 min to review, merge, and release to production and not crash in the hand of thousands of users
  • i have read the CONTRIBUTING.md file
  • i have updated the documentation if necessary
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:09am

Copy link

algora-pbc bot commented Nov 13, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@louis030195
Copy link
Collaborator

@developerfred

it's not solving the problem

the problem is that it does not render in app ui:

Screenshot 2024-11-13 at 9 29 51 AM

@developerfred
Copy link
Author

I’ll get back to this issue, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bounty] enable x265 on macos
2 participants