feat: let user select the directory to save things #680
+180
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
louis030195
reviewed
Nov 14, 2024
| .ok_or_else(|| anyhow::anyhow!("failed to get home directory"))? | ||
| .join(".screenpipe"); | ||
|
|
||
| // check .screenpipe_dir file whether it exists in default_path, if so, replace default_path | ||
| let screenpipe_dir_path = default_path.join(".screenpipe_dir"); |
There was a problem hiding this comment.
what is .screenpipe_dir? don't recall ever using this dir
this is mine with default data dir
|
overall great contribution i wonder if all still work well like including pipes which rely on the https://docs.screenpi.pe/docs/plugins#available-pipes i use the reddit one which rely on the dir, it writes logs of your day using AI and then search for relevant reddit posts based on these logs and generate answer to it can you explain the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #669
/closes #669
the summay of changes:
ui
tauri
load_pipe_config,save_pipe_config,reset_all_pipes(unverified)server
I have no clue to check pip-store related changes works, the remains mentioned above all manually checked in my mac-air-m3 device, both dev and build. some missing may occur due to the lack of my knowledge.