chore(#337): fix e2e tests on CI #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latin-panda
approved these changes
Mar 11, 2024
m5r
reviewed
Mar 11, 2024
|
For the record, I now believe that the main issue that was causing these tests to break was the WebView version being used in the emulated Android devices for the GH actions. The tests were originally running with Android 10. When I spin up an emulated version of Android 10 locally, it loads with webview So, I expect the upgrade to run with a newer version of Android was all that was needed for these tests, but I will retain the other changes here too since they are good to have as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337
Upgrade our way out of the CI test failures. Uplifts all our
androidTestImplementationdependencies to the latest versions. Also updates our GitHub actions jobs for running the tests to use Ubuntu and build against Android 33. This has the added benefit of making the tests run quite a bit faster for some reason...